From 083bcb07c2b3466412b60efce670931ee81d2a23 Mon Sep 17 00:00:00 2001 From: Dominic Date: Thu, 16 Nov 2023 11:52:17 +0100 Subject: [PATCH] fix incorrectly setting vaapi output when copying codec --- src/render/ffmpeg.rs | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/render/ffmpeg.rs b/src/render/ffmpeg.rs index ec76a8b..6eb642f 100644 --- a/src/render/ffmpeg.rs +++ b/src/render/ffmpeg.rs @@ -257,16 +257,18 @@ impl Ffmpeg { // append encoding options const QUALITY: &str = "22"; - if vaapi { - cmd.arg("-c:v").arg("h264_vaapi"); - if self.video_bitrate.is_none() { - cmd.arg("-rc_mode").arg("CQP"); - cmd.arg("-global_quality").arg(QUALITY); - } - } else if venc { - cmd.arg("-c:v").arg("libx264"); - if self.video_bitrate.is_none() { - cmd.arg("-crf").arg(QUALITY); + if venc { + if vaapi { + cmd.arg("-c:v").arg("h264_vaapi"); + if self.video_bitrate.is_none() { + cmd.arg("-rc_mode").arg("CQP"); + cmd.arg("-global_quality").arg(QUALITY); + } + } else { + cmd.arg("-c:v").arg("libx264"); + if self.video_bitrate.is_none() { + cmd.arg("-crf").arg(QUALITY); + } } } else { cmd.arg("-c:v").arg("copy");